Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 18 migration #891

Merged
merged 6 commits into from Sep 25, 2023
Merged

React 18 migration #891

merged 6 commits into from Sep 25, 2023

Conversation

neenu-chacko
Copy link
Contributor

@neenu-chacko neenu-chacko commented Sep 18, 2023 •
edited

Description

Checklist

  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@unnitallman unnitallman temporarily deployed to neeto-editor-pr-891 September 18, 2023 13:07 Inactive
@neenu-chacko neenu-chacko self-assigned this Sep 18, 2023
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-891 September 18, 2023 13:48 Inactive
@neenu-chacko
Copy link
Contributor Author

@AbhayVAshokan _a

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned neenu-chacko Sep 18, 2023
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-891 September 20, 2023 05:03 Inactive
@AbhayVAshokan
Copy link
Member

AbhayVAshokan commented Sep 21, 2023 •
edited

@neenu-chacko I managed to upgrade the storybook to the latest version and the warning still persists.

Here is a reference from the storybook team: storybookjs/storybook#17831 (comment). It seems like this is still not fixed on their end. This is only present on the documentation side. So it should work fine. Please assign the PR to Gaagul for a thorough verification if everything else is done.

@neenu-chacko neenu-chacko added the patch Releases small requests or bug fixes. label Sep 21, 2023
@neenu-chacko neenu-chacko marked this pull request as ready for review September 21, 2023 10:37
@neenu-chacko
Copy link
Contributor Author

@gaagul _a Please thoroughly test and verify everything works as expected.

@neetogit-bot neetogit-bot bot assigned gaagul and unassigned AbhayVAshokan Sep 21, 2023
@gaagul
Copy link
Contributor

gaagul commented Sep 25, 2023

@gaagul _a Please thoroughly test and verify everything works as expected.

LGTM

@gaagul gaagul merged commit 321cf29 into main Sep 25, 2023
@gaagul gaagul deleted the 890-react-18-migration branch September 25, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan Awaiting requested review from AbhayVAshokan AbhayVAshokan is a code owner

Assignees

@gaagul gaagul

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React 18 migration
5 participants
@neenu-chacko @AbhayVAshokan @gaagul @unnitallman @bot-bigbinary