Add example failing test for issue #2656 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example failing test for mockito#2656
5 tasks
big-andy-coates
commented
May 31, 2022
| * For examples how to use 'Mock' annotation and parameters see {@link Mock}. | ||
| * | ||
| * @since 4.6.0 | ||
| */ | ||
| Strictness strictness() default Strictness.STRICT_STUBS; | ||
| Strictness strictness() default Strictness.NOT_SET; |
There was a problem hiding this comment.
This method now returns local Strictness enum with a NOT_SET default.
(This is a breaking change for any code written using the strictness value of the annotation though)
big-andy-coates
commented
May 31, 2022
src/main/java/org/mockito/Mock.java
Outdated
Comment on lines
126
to
127
| // Todo: unit test to ensure all values covered | ||
| enum Strictness { |
There was a problem hiding this comment.
I can add a test to ensure the two enums are kept in sync.
big-andy-coates
commented
May 31, 2022
Comment on lines
+51
to
+53
| if (annotation.strictness() != Mock.Strictness.NOT_SET) { | ||
| mockSettings.strictness(annotation.strictness().outer()); | ||
| } |
There was a problem hiding this comment.
Now we can not set strictness on the settings...
big-andy-coates
commented
May 31, 2022
| @@ -45,7 +45,7 @@ | |||
| private boolean useConstructor; | |||
| private Object outerClassInstance; | |||
| private Object[] constructorArgs; | |||
| protected Strictness strictness = Strictness.STRICT_STUBS; | |||
| protected Strictness strictness = null; | |||
There was a problem hiding this comment.
And we change the default to null...
big-andy-coates
commented
May 31, 2022
| if (strictness == null) { | ||
| throw strictnessDoesNotAcceptNullParameter(); | ||
| } | ||
| this.strictness = strictness; |
There was a problem hiding this comment.
Moved as we shouldn't be mutating state on a bad input...
big-andy-coates
commented
May 31, 2022
| @@ -20,7 +20,7 @@ public class StrictnessMockAnnotationTest { | |||
|
|
|||
| public @Rule MockitoRule rule = MockitoJUnit.rule().strictness(Strictness.STRICT_STUBS); | |||
|
|
|||
| @Mock(strictness = Strictness.LENIENT) | |||
| @Mock(strictness = Mock.Strictness.LENIENT) | |||
There was a problem hiding this comment.
This is an example of the breaking change...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example failing test for mockito#2656