Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Avoid jinja2 v3 until nbconvert handles breakages #823

Merged
merged 3 commits into from Mar 25, 2022

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Mar 25, 2022

Jinja2 is breaking everything for everybody. We don't directly depend on it, but nbconvert doesn't have fixes out yet.

Also, it seems setuptools stopped packaging data in 61.0.0.

xref jupyter/nbconvert#1737 pypa/setuptools#3196

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #823 (ede7f96) into master (7af6c9e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   85.94%   85.94%           
=======================================
  Files          35       35           
  Lines        3912     3914    +2     
  Branches     1001     1001           
=======================================
+ Hits         3362     3364    +2     
  Misses        357      357           
  Partials      193      193           
Impacted Files Coverage Δ
bids/layout/layout.py 88.36% <0.00%> (+0.02%) ⬆️
bids/layout/index.py 84.98% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af6c9e...ede7f96. Read the comment docs.

@effigies effigies merged commit 4b19b36 into bids-standard:master Mar 25, 2022
@effigies effigies deleted the mnt/avoid_jinja2v3 branch March 25, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant