BEP032: ephys -> {icephys, ecephys} #1806
Conversation
yarikoptic
requested review from
TheChymera,
bendichter,
lzehl,
twachtler and
SylvainTakerkart
and removed request for
erdalkaraca and
tsalo
|
Looks good to me. |
|
Pending of course potential updates from the discussion. |
|
@yarikoptic Do you intend to fix this up according to #1800 (comment) or should we close this? |
|
let me fix it up to reflect #1800 ... will do now |
yarikoptic
changed the title
…lectrode Electrophysiology bids-standard#1800 (comment) Consensus reached during working group meeting on 2024-05-15: - modality = "Microelectrode Electrophysiology" - datatypes = "icephys" and "ecephys" - suffixes = "_icephys" and "_ecephys"
I might actually keep it plural and then make |
|
I would also ask everyone to suggest using github suggestions mechanism, see e.g https://stackoverflow.com/questions/54239733/how-can-i-manually-add-suggestions-in-code-reviews-on-github on howto. Can even span multiple lines |
|
It was grammar - "Electrophysiological data from an extracellular microelectrodes" -- the an is problematic if plural. |
ah, indeed! |
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
|
FWIW -- pre-commit and check_links whining are not on changes in this PR |
|
ok, thanks everyone who participated -- let's proceed by merging into bep032 branch to avoid possible conflicts with other works. I will squash |
Implements
Didn't want to push to bep032 since not yet agreed upon by @bids-standard/bep032 but wanted to be ready when/if we decide to proceed.
Closes #1800