Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace once_cell::sync::Lazy with std::sync::OnceLock #757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace once_cell::sync::Lazy with std::sync::OnceLock #757

wants to merge 1 commit into from

Conversation

nibon7
Copy link

@nibon7 nibon7 commented Feb 8, 2024

Since MSRV has been bumped to 1.70.0, I think it's time to remove the once_cell crate from the dependency tree.

samueltardieu
samueltardieu approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@FilipAndersson245
Copy link

looks fine, trimming dependencies fat is always nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nibon7 @FilipAndersson245 @samueltardieu