Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set minimum patch version for atty #587

Merged
merged 2 commits into from Jul 2, 2022

Commits on Jun 27, 2022

  1. set minimum patch version for atty

    atty <= 0.2.5 depends on winapi 0.2, which does not compile w/ nightly
    rust. Example output (rust version 1.64.0-nightly (c80c4b8fd 2022-06-26)):
    
    ```
    error[E0592]: duplicate definitions with name `item`
    --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\macros.rs:134:13
    |
    134|            pub unsafe fn $variant(&self) -> &$fieldtype {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    | |
    | duplicate definitions for `item`
    | other definition for `item`
    |
    ::: C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\commctrl.rs:2889:1
    |
    2889|UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA);
    | ---------------------------------------------------------in this macro invocation
    |
    = note: this error originates in the macro `UNION` (in Nightly builds, run with -Z macro-backtrace for more info)
    error[E0592]: duplicate definitions with name `item_mut`
    --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\macros.rs:138:13
    |
    138|            pub unsafe fn $variantmut(&mut self) -> &mut $fieldtype {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    | |
    | duplicate definitions for `item_mut`
    | other definition for `item_mut`
    |
    ::: C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\commctrl.rs:2889:1
    |
    2889|UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA);
    | ---------------------------------------------------------in this macro invocation
    |
    = note: this error originates in the macro `UNION` (in Nightly builds, run with -Z macro-backtrace for more info)
    ```
    
    I'm using https://github.com/taiki-e/cargo-minimal-versions to test if
    my library passes tests w/ minimal versions and currently it fails
    because of atty / this crate. See https://github.com/webrtc-rs/sdp/runs/7072368640?check_suite_focus=true
    melekes committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    325007b View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. Configuration menu
    Copy the full SHA
    c6bb31d View commit details
    Browse the repository at this point in the history