set minimum patch version for atty #587

melekes · 2022-06-27T12:37:29Z

atty <= 0.2.5 depends on winapi 0.2, which does not compile w/ nightly
rust. Example output (rust version 1.64.0-nightly (c80c4b8fd 2022-06-26)):

error[E0592]: duplicate definitions with name `item`
--> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\macros.rs:134:13
|
134|            pub unsafe fn $variant(&self) -> &$fieldtype {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| duplicate definitions for `item`
| other definition for `item`
|
::: C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\commctrl.rs:2889:1
|
2889|UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA);
| ---------------------------------------------------------in this macro invocation
|
= note: this error originates in the macro `UNION` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0592]: duplicate definitions with name `item_mut`
--> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\macros.rs:138:13
|
138|            pub unsafe fn $variantmut(&mut self) -> &mut $fieldtype {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| duplicate definitions for `item_mut`
| other definition for `item_mut`
|
::: C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\commctrl.rs:2889:1
|
2889|UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA);
| ---------------------------------------------------------in this macro invocation
|
= note: this error originates in the macro `UNION` (in Nightly builds, run with -Z macro-backtrace for more info)

I'm using https://github.com/taiki-e/cargo-minimal-versions to test if
my library passes tests w/ minimal versions and currently it fails
because of atty / this crate. See https://github.com/webrtc-rs/sdp/runs/7072368640?check_suite_focus=true

atty <= 0.2.5 depends on winapi 0.2, which does not compile w/ nightly rust. Example output (rust version 1.64.0-nightly (c80c4b8fd 2022-06-26)): ``` error[E0592]: duplicate definitions with name `item` --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\macros.rs:134:13 | 134| pub unsafe fn $variant(&self) -> &$fieldtype { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | duplicate definitions for `item` | other definition for `item` | ::: C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\commctrl.rs:2889:1 | 2889|UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA); | ---------------------------------------------------------in this macro invocation | = note: this error originates in the macro `UNION` (in Nightly builds, run with -Z macro-backtrace for more info) error[E0592]: duplicate definitions with name `item_mut` --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\macros.rs:138:13 | 138| pub unsafe fn $variantmut(&mut self) -> &mut $fieldtype { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | duplicate definitions for `item_mut` | other definition for `item_mut` | ::: C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\commctrl.rs:2889:1 | 2889|UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA); | ---------------------------------------------------------in this macro invocation | = note: this error originates in the macro `UNION` (in Nightly builds, run with -Z macro-backtrace for more info) ``` I'm using https://github.com/taiki-e/cargo-minimal-versions to test if my library passes tests w/ minimal versions and currently it fails because of atty / this crate. See https://github.com/webrtc-rs/sdp/runs/7072368640?check_suite_focus=true

melekes · 2022-06-27T12:38:50Z

Please let me know if this change is not desired or if you want me to make any changes. Thanks 🙏

"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

* update deps + loosen some requirements rules: - for crates that are below v1.0 -> specify the precise version - If the code uses a feature that was added for example in X 0.3.17, then you should specify 0.3.17, which actually means "0.3.y where y >= 17" - for crates the are above or equal v1.0 -> specify only major version if the crate's API is minimal and won't change between minor versions OR specify major&minor versions otherwise tested with https://github.com/taiki-e/cargo-minimal-versions * fix warnings * update util version * format code * disable 'windows-latest' until criterion#atty version is upgraded "0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

* update deps + loosen some requirements rules: - for crates that are below v1.0 -> specify the precise version (unless crates readme says otherwise) - If the code uses a feature that was added for example in X 0.3.17, then you should specify 0.3.17, which actually means "0.3.y where y >= 17" - for crates the are above or equal v1.0 -> specify only major version if the crate's API is minimal and won't change between minor versions (unless crates readme says otherwise) OR specify major&minor versions otherwise tested with https://github.com/taiki-e/cargo-minimal-versions * .github: test min Rust version * fix warnings * update util version * disable 'windows-latest' until criterion#atty version is upgraded "0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

* update deps + loosen some requirements rules: - for crates that are below v1.0 -> specify the precise version - If the code uses a feature that was added for example in X 0.3.17, then you should specify 0.3.17, which actually means "0.3.y where y >= 17" - for crates the are above or equal v1.0 -> specify only major version if the crate's API is minimal and won't change between minor versions OR specify major&minor versions otherwise tested with https://github.com/taiki-e/cargo-minimal-versions * fix warnings * update util version * disable 'windows-latest' until criterion#atty version is upgraded "0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

* update deps + loosen some requirements rules: - for crates that are below v1.0 -> specify the precise version - If the code uses a feature that was added for example in X 0.3.17, then you should specify 0.3.17, which actually means "0.3.y where y >= 17" - for crates the are above or equal v1.0 -> specify only major version if the crate's API is minimal and won't change between minor versions OR specify major&minor versions otherwise tested with https://github.com/taiki-e/cargo-minimal-versions * fix warnings * update util version * format code * disable 'windows-latest' until criterion#atty version is upgraded "0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

* update deps + loosen some requirements rules: - for crates that are below v1.0 -> specify the precise version (unless crates readme says otherwise) - If the code uses a feature that was added for example in X 0.3.17, then you should specify 0.3.17, which actually means "0.3.y where y >= 17" - for crates the are above or equal v1.0 -> specify only major version if the crate's API is minimal and won't change between minor versions (unless crates readme says otherwise) OR specify major&minor versions otherwise tested with https://github.com/taiki-e/cargo-minimal-versions * .github: test min Rust version * fix warnings * update util version * disable 'windows-latest' until criterion#atty version is upgraded "0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

* update deps + loosen some requirements rules: - for crates that are below v1.0 -> specify the precise version - If the code uses a feature that was added for example in X 0.3.17, then you should specify 0.3.17, which actually means "0.3.y where y >= 17" - for crates the are above or equal v1.0 -> specify only major version if the crate's API is minimal and won't change between minor versions OR specify major&minor versions otherwise tested with https://github.com/taiki-e/cargo-minimal-versions * fix warnings * update util version * disable 'windows-latest' until criterion#atty version is upgraded "0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

melekes added a commit to webrtc-rs/rtp that referenced this pull request Jun 27, 2022

disable 'windows-latest' until criterion#atty version is upgraded

f3e7fa5

"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

melekes added a commit to webrtc-rs/turn that referenced this pull request Jun 27, 2022

disable 'windows-latest' until atty version is upgraded

1db144f

"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

melekes added a commit to melekes/webrtc-stun that referenced this pull request Jun 27, 2022

disable 'windows-latest' until criterion#atty version is upgraded

6fcffe3

"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

melekes added a commit to webrtc-rs/media that referenced this pull request Jun 27, 2022

disable 'windows-latest' until criterion#atty version is upgraded

b1c1711

"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587

Merge branch 'master' into anton/atty-version

c6bb31d

lemmih approved these changes Jul 2, 2022

View reviewed changes

lemmih merged commit ff2ec14 into bheisler:master Jul 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set minimum patch version for atty #587

set minimum patch version for atty #587

melekes commented Jun 27, 2022

melekes commented Jun 27, 2022

set minimum patch version for atty #587

set minimum patch version for atty #587

Conversation

melekes commented Jun 27, 2022

melekes commented Jun 27, 2022