set minimum patch version for atty #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atty <= 0.2.5 depends on winapi 0.2, which does not compile w/ nightly
rust. Example output (rust version 1.64.0-nightly (c80c4b8fd 2022-06-26)):
```
error[E0592]: duplicate definitions with name `item`
--> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\macros.rs:134:13
|
134| pub unsafe fn $variant(&self) -> &$fieldtype {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| duplicate definitions for `item`
| other definition for `item`
|
::: C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\commctrl.rs:2889:1
|
2889|UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA);
| ---------------------------------------------------------in this macro invocation
|
= note: this error originates in the macro `UNION` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0592]: duplicate definitions with name `item_mut`
--> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\macros.rs:138:13
|
138| pub unsafe fn $variantmut(&mut self) -> &mut $fieldtype {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| duplicate definitions for `item_mut`
| other definition for `item_mut`
|
::: C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\winapi-0.2.4\src\commctrl.rs:2889:1
|
2889|UNION!(TVINSERTSTRUCTA, itemex, item, item_mut, TV_ITEMA);
| ---------------------------------------------------------in this macro invocation
|
= note: this error originates in the macro `UNION` (in Nightly builds, run with -Z macro-backtrace for more info)
```
I'm using https://github.com/taiki-e/cargo-minimal-versions to test if
my library passes tests w/ minimal versions and currently it fails
because of atty / this crate. See https://github.com/webrtc-rs/sdp/runs/7072368640?check_suite_focus=true
|
Please let me know if this change is not desired or if you want me to make any changes. Thanks 🙏 |
melekes
added a commit
to webrtc-rs/rtp
that referenced
this pull request
Jun 27, 2022
"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587
melekes
added a commit
to webrtc-rs/rtp
that referenced
this pull request
Jun 27, 2022
* update deps + loosen some requirements
rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
then you should specify 0.3.17, which actually means "0.3.y where y >=
17"
- for crates the are above or equal v1.0 -> specify only major version
if the crate's API is minimal and won't change between minor versions
OR specify major&minor versions otherwise
tested with https://github.com/taiki-e/cargo-minimal-versions
* fix warnings
* update util version
* format code
* disable 'windows-latest' until criterion#atty version is upgraded
"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not
compile on nightly.
bheisler/criterion.rs#587
melekes
added a commit
to webrtc-rs/turn
that referenced
this pull request
Jun 27, 2022
"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587
melekes
added a commit
to melekes/webrtc-stun
that referenced
this pull request
Jun 27, 2022
"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587
melekes
added a commit
to webrtc-rs/stun
that referenced
this pull request
Jun 27, 2022
* update deps + loosen some requirements rules: - for crates that are below v1.0 -> specify the precise version (unless crates readme says otherwise) - If the code uses a feature that was added for example in X 0.3.17, then you should specify 0.3.17, which actually means "0.3.y where y >= 17" - for crates the are above or equal v1.0 -> specify only major version if the crate's API is minimal and won't change between minor versions (unless crates readme says otherwise) OR specify major&minor versions otherwise tested with https://github.com/taiki-e/cargo-minimal-versions * .github: test min Rust version * fix warnings * update util version * disable 'windows-latest' until criterion#atty version is upgraded "0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587
melekes
added a commit
to webrtc-rs/media
that referenced
this pull request
Jun 27, 2022
"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587
melekes
added a commit
to webrtc-rs/media
that referenced
this pull request
Jun 27, 2022
* update deps + loosen some requirements
rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
then you should specify 0.3.17, which actually means "0.3.y where y >=
17"
- for crates the are above or equal v1.0 -> specify only major version
if the crate's API is minimal and won't change between minor versions
OR specify major&minor versions otherwise
tested with https://github.com/taiki-e/cargo-minimal-versions
* fix warnings
* update util version
* disable 'windows-latest' until criterion#atty version is upgraded
"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not
compile on nightly.
bheisler/criterion.rs#587
lemmih
approved these changes
Jul 2, 2022
algesten
pushed a commit
to webrtc-rs/webrtc
that referenced
this pull request
Aug 23, 2022
* update deps + loosen some requirements
rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
then you should specify 0.3.17, which actually means "0.3.y where y >=
17"
- for crates the are above or equal v1.0 -> specify only major version
if the crate's API is minimal and won't change between minor versions
OR specify major&minor versions otherwise
tested with https://github.com/taiki-e/cargo-minimal-versions
* fix warnings
* update util version
* format code
* disable 'windows-latest' until criterion#atty version is upgraded
"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not
compile on nightly.
bheisler/criterion.rs#587
algesten
pushed a commit
to webrtc-rs/webrtc
that referenced
this pull request
Aug 23, 2022
* update deps + loosen some requirements rules: - for crates that are below v1.0 -> specify the precise version (unless crates readme says otherwise) - If the code uses a feature that was added for example in X 0.3.17, then you should specify 0.3.17, which actually means "0.3.y where y >= 17" - for crates the are above or equal v1.0 -> specify only major version if the crate's API is minimal and won't change between minor versions (unless crates readme says otherwise) OR specify major&minor versions otherwise tested with https://github.com/taiki-e/cargo-minimal-versions * .github: test min Rust version * fix warnings * update util version * disable 'windows-latest' until criterion#atty version is upgraded "0.2" min version (0.2.0) depends on winapi-0.2.4 which does not compile on nightly. bheisler/criterion.rs#587
algesten
pushed a commit
to webrtc-rs/webrtc
that referenced
this pull request
Aug 23, 2022
* update deps + loosen some requirements
rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
then you should specify 0.3.17, which actually means "0.3.y where y >=
17"
- for crates the are above or equal v1.0 -> specify only major version
if the crate's API is minimal and won't change between minor versions
OR specify major&minor versions otherwise
tested with https://github.com/taiki-e/cargo-minimal-versions
* fix warnings
* update util version
* disable 'windows-latest' until criterion#atty version is upgraded
"0.2" min version (0.2.0) depends on winapi-0.2.4 which does not
compile on nightly.
bheisler/criterion.rs#587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atty <= 0.2.5 depends on winapi 0.2, which does not compile w/ nightly
rust. Example output (rust version 1.64.0-nightly (c80c4b8fd 2022-06-26)):
I'm using https://github.com/taiki-e/cargo-minimal-versions to test if
my library passes tests w/ minimal versions and currently it fails
because of atty / this crate. See https://github.com/webrtc-rs/sdp/runs/7072368640?check_suite_focus=true