Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix dataplane observability configuration remote write url description #1714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miguelsorianod
Copy link
Contributor

Description

The documentation was referencing obsolete attribute names in the configuration. This set of changes updates those references to the currently defined names.

Verification Steps

  • The YAML sample file is a valid YAML

Checklist (Definition of Done)

  • All acceptance criteria specified in JIRA have been completed
  • Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer
  • All PR comments are resolved either by addressing them or creating follow up tasks
  • Required metrics/dashboards/alerts have been added (or PR created).
  • Required Standard Operating Procedure (SOP) is added.
  • JIRA has been created for changes required on the client side

@miguelsorianod miguelsorianod requested a review from a team as a code owner April 17, 2023 16:05
The documentation was referencing obsolete attribute names
in the configuration. This set of changes updates those
references to the currently defined names.
@miguelsorianod miguelsorianod force-pushed the fix-dataplane-obsconfg-remotewriteurl-doc branch from eca38c3 to 26a86b4 Compare April 17, 2023 16:06
@miguelsorianod
Copy link
Contributor Author

cc @pb82 @machi1990 can you review that I documented it properly and that I am not "swapping" the behavior?

Thank you

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1714 (26a86b4) into main (7e9dd15) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
- Coverage   82.19%   82.19%   -0.01%     
==========================================
  Files         161      161              
  Lines       14999    14997       -2     
==========================================
- Hits        12329    12327       -2     
  Misses       2235     2235              
  Partials      435      435              
Flag Coverage Δ
unittests 82.19% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants