build(deps): bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0 #1247
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
|
@dependabot rebase |
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.12.2 to 1.13.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.12.2...v1.13.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/prometheus/client_golang-1.13.0
branch
from
bdd51a0
to
c942877
Compare
|
I've been working on this. The tests were failing and the cause of the issue was that I updated KFM code to comply with the new signatures. After reading the changelog it seems we should be safe to update too. The two most important changes seem to be:
If the tests pass I think we should be ok to merge. |
| @@ -26,13 +28,13 @@ func (t *httpAPIMock) QueryExemplars(ctx context.Context, query string, startTim | |||
| } | |||
|
|
|||
| // performs a query for the kafka metrics. | |||
| func (t *httpAPIMock) Query(ctx context.Context, query string, ts time.Time) (pModel.Value, pV1.Warnings, error) { | |||
| func (t *httpAPIMock) Query(ctx context.Context, query string, ts time.Time, opts ...pV1.Option) (pModel.Value, pV1.Warnings, error) { | |||
There was a problem hiding this comment.
cc @pb82 to review the changes in this PR.
I think with the changes we've done in this PR we are ok. We don't need to take the options into account at all due to this is part of the httpAPIMock type which is a mock and we don't need to process them at all.
Independently on that maybe we should consider if it would be interesting to process the options when using the real client in a future PR if we deem it would be useful. cc @pb82
There was a problem hiding this comment.
thanks for updating this @miguelsorianod
Looks like the only available option at the moment is a timeout: https://github.com/prometheus/client_golang/blob/83d56b1144a0c2eb10d399e7abbae3333bebc463/api/prometheus/v1/api.go#L820
But regardless, it can be useful in the future.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
=======================================
Coverage 82.89% 82.89%
=======================================
Files 137 137
Lines 12057 12057
=======================================
Hits 9995 9995
Misses 1697 1697
Partials 365 365
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@dependabot merge |
dependabot
bot
deleted the
dependabot/go_modules/github.com/prometheus/client_golang-1.13.0
branch
Bumps github.com/prometheus/client_golang from 1.12.2 to 1.13.0.
Release notes
Sourced from github.com/prometheus/client_golang's releases.
... (truncated)
Changelog
Sourced from github.com/prometheus/client_golang's changelog.
Commits
64435fcCut 1.13.0 (#1110)5b7e8b2collectors.GoCollector: Added rule support for granular metric configuration....d44fbbeFix build against GopherJS (#897)1638da9testutil: Add ScrapeAndCompare (#1043)c576b95Generate new Go runtime metrics for go 1.19 (#1105)618194dfix assorted oddities found by golangci-lint (#1040)c7488beAdded exemplar support to http middleware. (#1055)3faf3baFixed support for unordered input of exemplars. (#1100)44ce5e1Ensure tests verify request params (#1047)807b1eeexplicitly add +inf bucket in withExemplarsMetric (#1094)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)