Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix instancing example for hdr #6554

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix instancing example for hdr #6554

wants to merge 1 commit into from

Conversation

aevyrie
Copy link
Member

@aevyrie aevyrie commented Nov 12, 2022

Objective

  • Using the instancing example as reference, I found it was breaking when enabling HDR on the camera. I found that this was because, unlike in internal code, this was not updating the specialization key with view.hdr.

Solution

  • Add the missing HDR bit.

@aevyrie aevyrie added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Nov 12, 2022
@ickk ickk added the C-Examples An addition or correction to our examples label Nov 12, 2022
@Weibye Weibye added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 12, 2022
@mockersf
Copy link
Member

Bors r+

bors bot pushed a commit that referenced this pull request Nov 12, 2022
@aevyrie
Fix instancing example for hdr (#6554)
c3c4088 
# Objective

- Using the instancing example as reference, I found it was breaking when enabling HDR on the camera. I found that this was because, unlike in internal code, this was not updating the specialization key with `view.hdr`.

## Solution

- Add the missing HDR bit.
@bors
Copy link
Contributor

bors bot commented Nov 12, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix instancing example for hdr [Merged by Bors] - Fix instancing example for hdr Nov 12, 2022
@bors bors bot closed this Nov 12, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@aevyrie @ItsDoot
Fix instancing example for hdr (bevyengine#6554)
8b174fc 
# Objective

- Using the instancing example as reference, I found it was breaking when enabling HDR on the camera. I found that this was because, unlike in internal code, this was not updating the specialization key with `view.hdr`.

## Solution

- Add the missing HDR bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@Weibye Weibye Weibye approved these changes

@jakobhellermann jakobhellermann jakobhellermann approved these changes

@irate-devil irate-devil irate-devil approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aevyrie @mockersf @Weibye @jakobhellermann @irate-devil @ickk