Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplified chinese translation for home page #831

Closed
wants to merge 3 commits into from

Conversation

lomirus
Copy link

@lomirus lomirus commented Nov 16, 2023

Added simplified chinese translation for home page. You can access it by http://127.0.0.1:1111/zh_cn/.

The links for images was changed to absolute paths from relative path in order to be able to be accessed in sub path like /zh-cn/.

This PR only adds the translation, but does not add the link for users to access this page (/zh_cn/) in website, because I think it should be another issue: the UI change (language switcher) for multi-language should be discussed further.

#317 has discussed the translation strategies but has not provided a way to track translation progress yet, so maybe this PR can remain open until we sort out the way.

templates/index.zh_cn.html Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added A-Home X-Controversial There is active debate or serious implications around merging this PR labels Jan 21, 2024
@alice-i-cecile
Copy link
Member

I don't think this is an initiative we can pursue right now <3 Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Home X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants