-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix On This Page algorithm #1170
Fix On This Page algorithm #1170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tho why do we use <h3>
instead of <h2>
as the next step down from a <h1>
in the migration guides I wonder. Semantically weird, and style-wise a <h2>
can be styled to look correctly.
The code from that is pretty old, so my guess is just that cart liked the look of a h3 better and nobody questioned it since, but yeah, we should just use h2 and update the styling |
scope creep >.< edit: re-requesting because, well, i added more stuff. updated description. |
Will rebase when I get home tomorrow |
45854e7
to
68a12af
Compare
Also request from @Jondolf because after rebasing i had to mess with your styles |
@SIGSTACKFAULT once merge conflicts are resolved I'll merge this in for you. |
instead of what's apparently the top border width.
68a12af
to
841c98b
Compare
@alice-i-cecile resolved! |
scope-creep edition!
<h2>
s (which is the case on migration guides)<a href>
which need to be there anyway instead of<li data-fragment>