Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix On This Page algorithm #1170

Merged
merged 5 commits into from
May 21, 2024

Conversation

SIGSTACKFAULT
Copy link
Contributor

@SIGSTACKFAULT SIGSTACKFAULT commented May 16, 2024

scope-creep edition!

  • sort by the actual Y position. and not the top border width.
  • sort in the correct direction
  • handle the case where there are no <h2>s (which is the case on migration guides)
  • compare <a href> which need to be there anyway instead of <li data-fragment>

@alice-i-cecile alice-i-cecile added C-Bug A problem with the code that runs the site C-Webdev labels May 16, 2024
Copy link
Member

@TrialDragon TrialDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tho why do we use <h3> instead of <h2> as the next step down from a <h1> in the migration guides I wonder. Semantically weird, and style-wise a <h2> can be styled to look correctly.

@IceSentry
Copy link
Contributor

IceSentry commented May 16, 2024

Tho why do we use <h3> instead of <h2>

The code from that is pretty old, so my guess is just that cart liked the look of a h3 better and nobody questioned it since, but yeah, we should just use h2 and update the styling

@SIGSTACKFAULT
Copy link
Contributor Author

SIGSTACKFAULT commented May 17, 2024

scope creep >.<

edit: re-requesting because, well, i added more stuff. updated description.

@SIGSTACKFAULT
Copy link
Contributor Author

Will rebase when I get home tomorrow

@SIGSTACKFAULT
Copy link
Contributor Author

Also request from @Jondolf because after rebasing i had to mess with your styles

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels May 21, 2024
@alice-i-cecile
Copy link
Member

@SIGSTACKFAULT once merge conflicts are resolved I'll merge this in for you.

@SIGSTACKFAULT
Copy link
Contributor Author

@alice-i-cecile resolved!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 21, 2024
Merged via the queue into bevyengine:main with commit f3b2c21 May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug A problem with the code that runs the site C-Webdev S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants