Simpler subjects names for imports #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucienMLD
reviewed
Oct 6, 2020
| [theme, subject, description.presence].compact.to_csv(col_sep: ':').strip | ||
| def unique_name | ||
| if similar_institutions_subjects.present? | ||
| "#{subject.label}:#{description}" # We know description isn‘t blank, see :validate_description_presence |
There was a problem hiding this comment.
Je pinaille mais on peut mettre des espaces autour du :
There was a problem hiding this comment.
Bof, le but est à la fois d’être lisible et de pouvoir matcher les possible_names, je préfère que ça soit plus simple.
n-b
force-pushed
the
simpler-subjects-names-for-imports
branch
from
23c0847
to
6f3c871
Compare
|
Merger #1300 d’abord pour corriger le bug de rubocop. |
* Make the Subject label unique * Make the InstitutionSubject [institution, subject, description] unique: it means that in an Institution, the same subject can only be selected several times if the description is different (and present.) refs #1253
On export, use just the subject as much as possible, and add the description if needed. On import, allow different possible combinations, as long as it’s unambiguous. refs #1253
n-b
force-pushed
the
simpler-subjects-names-for-imports
branch
from
6f3c871
to
56b7266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1253
Make sure InstitutionSubjects can be identifier by subject+description
Simplify the subject column name used in CSV exports and imports
The rubocop issue seems to be rubocop/rubocop-rails#349. We probably just need to bump the gem.