Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to rails 7 #388

Merged
merged 15 commits into from
Mar 28, 2022
Merged

Bump to rails 7 #388

merged 15 commits into from
Mar 28, 2022

Conversation

skelz0r
Copy link
Contributor

@skelz0r skelz0r commented Feb 23, 2022

Not green yet:

Finished in 10.21 seconds (files took 4.7 seconds to load)
230 examples, 8 failures, 2 pending

Failed examples:

rspec ./spec/controllers/enrollments/change_state_spec.rb:87 # EnrollmentsController#change_state submit event authorization with user when technical_team_type is missing when target_api is api_particulier is expected to respond with status code :unprocessable_entity (422)
rspec ./spec/controllers/enrollments/change_state_spec.rb:228 # EnrollmentsController#change_state validate event authorization with user when user is an instructor when user is an instructor for the enrollment target api when enrollment is in submitted mode when comment is missing is expected to respond with status code :unprocessable_entity (422)
rspec './spec/models/event_spec.rb[1:2:1:1:2:1]' # Event comment validation events which require comment presence when name is 'refuse' when comment is nil is expected not to be valid
rspec './spec/models/event_spec.rb[1:2:1:2:2:1]' # Event comment validation events which require comment presence when name is 'request_changes' when comment is nil is expected not to be valid
rspec './spec/models/event_spec.rb[1:2:1:3:2:1]' # Event comment validation events which require comment presence when name is 'validate' when comment is nil is expected not to be valid
rspec './spec/models/event_spec.rb[1:2:1:4:2:1]' # Event comment validation events which require comment presence when name is 'notify' when comment is nil is expected not to be valid
rspec ./spec/workers/deliver_enrollment_webhook_worker_spec.rb:148 # DeliverEnrollmentWebhookWorker when all target api webhook env vars are defined target's api webhook url status when endpoint respond with an error (400 to 599 status) when tries count is not 4 does not send an email through WebhookMailer
rspec ./spec/workers/deliver_enrollment_webhook_worker_spec.rb:168 # DeliverEnrollmentWebhookWorker when all target api webhook env vars are defined target's api webhook url status when endpoint respond with an error (400 to 599 status) when tries count is 4 (5th attempt, ~10m) sends an email through WebhookMailer

Deprecation warnings (TBD)

DEPRECATION WARNING: #extension_whitelist is deprecated, use #extension_allowlist instead. (called from block (3 levels) in <top (required)> at /Users/skelz0r/work/dinum/datapass/backend/spec/factories/documents.rb:12)
DEPRECATION WARNING: Non-URL-safe CSRF tokens are deprecated. Use 6.1 defaults or above. (called from <top (required)> at /Users/skelz0r/work/dinum/datapass/backend/spec/rails_helper.rb:9)

Issues to solve/watch:

  • uninitialized constant ActionMailer::Parameterized::DeliveryJob -> related RSpec Rails 6.0 Release Plan rspec/rspec-rails#2560 (waiting for a proper release of rspec-rails)
  • Make a proper migration for Enrollment inside app/models/enrollment/dgfip in database
  • Review

@skelz0r
Copy link
Contributor Author

skelz0r commented Feb 23, 2022

There's at least an another issue about class naming:

/home/runner/work/datapass/datapass/backend/app/models/document/geo_shapelegal_basis.rb to define constant Document::GeoShapelegalBasis, but didn't
bundler: failed to load command: puma (/home/runner/work/datapass/datapass/backend/vendor/bundle/ruby/2.7.0/bin/puma)
Zeitwerk::NameError: expected file /home/runner/work/datapass/datapass/backend/app/models/document/geo_shapelegal_basis.rb to define constant Document::GeoShapelegalBasis, but didn't

Spotted in e2e testing.

@rdubigny rdubigny force-pushed the bump/rails branch 2 times, most recently from 5fd1e13 to 5a83295 Compare March 8, 2022 16:03
@rdubigny rdubigny marked this pull request as ready for review March 9, 2022 09:51
@rdubigny
Copy link
Member

rdubigny commented Mar 9, 2022

Patch Monday !

@rdubigny
Copy link
Member

Patch Monday !

@rdubigny rdubigny merged commit 0e87a23 into master Mar 28, 2022
@rdubigny rdubigny deleted the bump/rails branch March 28, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants