-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to rails 7 #388
Merged
Merged
Bump to rails 7 #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's at least an another issue about class naming:
Spotted in e2e testing. |
rdubigny
force-pushed
the
bump/rails
branch
2 times, most recently
from
March 8, 2022 16:03
5fd1e13
to
5a83295
Compare
…an error is deprecated.
rdubigny
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not green yet:
Deprecation warnings (TBD)
Issues to solve/watch:
uninitialized constant ActionMailer::Parameterized::DeliveryJob
-> related RSpec Rails 6.0 Release Plan rspec/rspec-rails#2560 (waiting for a proper release of rspec-rails)Enrollment
insideapp/models/enrollment/dgfip
in database