Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration du cluster kubernetes #1064

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Configuration du cluster kubernetes #1064

wants to merge 8 commits into from

Conversation

niladic
Copy link
Collaborator

@niladic niladic commented Jun 2, 2021 •
edited

  • Il manque la config du Ingress
  • RETENTION_NUM_OF_DAYS est à mettre à une valeur convenable

@jdauphant jdauphant temporarily deployed to aplus-demo-task-kuberne-7kedya June 2, 2021 19:32 Inactive
@niladic niladic marked this pull request as draft June 2, 2021 19:33
@niladic niladic requested a review from jdauphant June 2, 2021 19:37
jdauphant
jdauphant reviewed Jun 3, 2021
View reviewed changes
kubernetes/aplus-db-backup-job.yaml
fi
done < <(swift --os-auth-token $AUTH_TOKEN --os-storage-url $STORAGE_URL list --json $STORAGE_CONTAINER | jq -c '.[]')
---
apiVersion: batch/v1beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est normal le v1beta1 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, la feature est stable à partir de kubernetes v1.21 https://kubernetes.io/docs/concepts/workloads/controllers/cron-jobs/ et on est sur v1.20 => Je vais ajouter un commentaire

jdauphant
jdauphant reviewed Jun 3, 2021
View reviewed changes
kubernetes/aplus-db.yaml Outdated
valueFrom:
secretKeyRef:
name: aplus-db-postgres-secret
key: DATABASE_URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je vois POSTGRES_PASSWORD et DATABASE_URL c'est normal ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien vu !

@niladic niladic marked this pull request as ready for review September 22, 2021 10:17
@niladic niladic marked this pull request as draft February 23, 2022 10:19
@niladic
Copy link
Collaborator Author

niladic commented Feb 23, 2022

Je laisse ouvert pour garder les reviews de Codacy, le code de cette PR est obsolète.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdauphant jdauphant Awaiting requested review from jdauphant

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niladic @jdauphant