New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with JDK16: Unsupported major.minor version 60.0 #176
Comments
Yes, ASM was most likely the cause. I upgraded to ASM 9.1 in release 2.23.4. |
Thanks for the quick turnaround! I tried the new version and am getting the same failure/stacktrace. Perhaps the problem is related to this:
I'm running Gradle 6.8.3 under JDK15, but using a JDK16 toolchain and Looking at the key section of the stack trace:
This would be running under JDK15, so that's probably the issue. I'll try running with a pre-release Gradle 7 under JDK 16 and let you know what happens. |
With the latest Gradle 7 nightly and JDK16 (16.0.0, AdoptOpenJDK Hotspot) I get the following error:
With the key bit of stack trace being:
|
OK, I think I've narrowed the problem down. It seems that using The 3 sample apps in the Supernaut.FX build have been building correctly, so I tried to see if I could trigger the failure in that project. So I did the following:
Here's the Gradle Build Scan of the failure: https://scans.gradle.com/s/6pkdbf5oqyvho So you should be able to check out the |
I was able to get the OmniMarketCap build working, by generating the
It turns out that the |
There are a few places in the plugin's code where the method ModuleDescriptor.read(InputStream) is called. These calls fail when the InputStream argument contains Java 16 bytecode and Gradle uses Java 15. I will try to execute these calls in a separate process that uses the required toolchain. It's a bit of a hack but it should work. I will do a new release in the next few days. |
Except the error above (see https://scans.gradle.com/s/6pkdbf5oqyvho ) is running Gradle under JDK 16. (I think this problem might have something to do with changed default visibility in JDK 16) |
p.s. I could create a new issue for the Gradle 7/JDK 16 error:
|
No need to create a new issue because I already identified the cause: an autocomplete fail in PackageCollection. I had entered:
instead of
|
Yeah, I was surprised by that package path. Was thinking it was weird that OpenJDK had created some internal support for ASM... |
I see that Gradle 7 RC1 came out yesterday, so i'll be updating to RC1. |
I just released 2.23.5, which fixes the I tested the plugin with one of my projects and it worked fine with Gradle 7.0-rc-1.
My workaround was to replace
with
So, updating to Gradle 7.0-rc-1 is probably the best option. |
OK, I upgraded 3 branches of SupernautFX to 2.23.5 and all are passing Github CI -- 2.23.5 looks good!
(I had already applied the I would upgrade ... and I just noticed that it is forked and released by @siordache -- you're single-handedly fixing all my blockers to a release built on JDK 16! OK, I can upgrade to Gradle 7.0-rc-1 on the master branch, now! Update: I fixed a typo where in 2 places I accidentally put JDK 17 where I meant JDK 16. |
Yes, I also need the hierynomus/license-gradle-plugin. For JDK 16 I use jitpack to get the version from my fork: |
OK, after SupernautApp/SupernautFX@941c728 Supernaut.FX |
* Need to increase javafxplugin version because of a bug exist for build with java11+ in moduleplugin which used in older versions of javafxplugin. It is fixed by openjfx/javafx-gradle-plugin#120 Which in merged with 0.0.12 * Need to increase jlink because of a bug exist in jlink for building java16 versions ( beryx/badass-jlink-plugin#176 )
I've been successfully building with Gradle running JDK15 and a JDK16 javaToolchain (in https://github.com/SupernautApp/SupernautFX, for example)
However, in another (unfortunately not Open Source) project, with a similar configuration, I'm getting:
Perhaps the ASM dependency needs to be upgraded to ASM 9.0 or 9.1?
The text was updated successfully, but these errors were encountered: