Build with Gradle 7 rc-1 and a single JDK (version 16.0.0) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable license plugin which is not compatible with Gradle 7
Use the same JDK (16) to run Gradle Daemon and Gradle Java Toolchain
msgilligan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work-in-progress.
We need to either wait for a new release of the Gradle License Plugin that we are using, or switch to a different plugin. (The fix for hierynomus/license-gradle-plugin#179 is committed, but not released.)
It would also be nice to have an updated Badass JLink Plugin because of beryx/badass-jlink-plugin#176 -- which does not affect the SupernautFX build, but could affect the build if we change settings on the
mergedModuleblock in a sample app, and can definitely affect Supernaut.FX apps if they are built with Gradle 7 and/or JDK 16.