Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implem new e2e tests #4504

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lucasdc99
Copy link
Contributor

@lucasdc99 lucasdc99 commented Nov 24, 2022

No description provided.

@lucasdc99 lucasdc99 requested a review from a team as a code owner November 24, 2022 16:12
@lucasdc99 lucasdc99 requested a review from a team as a code owner November 24, 2022 16:12
@lucasdc99 lucasdc99 self-assigned this Nov 24, 2022
@auto-add-label auto-add-label bot added the chore label Nov 24, 2022
@lucasdc99 lucasdc99 force-pushed the chore/implem-new-e2e-tests branch 2 times, most recently from b32976d to c805c4c Compare December 2, 2022 15:54
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 34.46% // Head: 34.45% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6ffee68) compared to base (e96f81d).
Patch coverage: 80.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4504      +/-   ##
==========================================
- Coverage   34.46%   34.45%   -0.02%     
==========================================
  Files         571      575       +4     
  Lines       35855    35849       -6     
  Branches     1842     1833       -9     
==========================================
- Hits        12356    12350       -6     
  Misses      22256    22256              
  Partials     1243     1243              
Flag Coverage Δ
js.unittests 44.28% <80.85%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/packages/components/InfosChat.tsx 6.06% <ø> (ø)
js/packages/components/chat/footer/ChatFooter.tsx 4.00% <ø> (ø)
...kages/components/chat/footer/ChatFooterButtons.tsx 17.64% <ø> (ø)
.../packages/components/chat/footer/ChatTextInput.tsx 19.23% <ø> (ø)
...omponents/chat/message/user-message/SenderName.tsx 20.00% <ø> (ø)
...-message/user-message-box/HyperlinkUserMessage.tsx 13.33% <ø> (ø)
js/packages/components/items/MenuItem.priv.tsx 100.00% <ø> (ø)
...s/packages/components/items/section/MenuToggle.tsx 100.00% <ø> (ø)
js/packages/components/onboarding/SwiperCard.tsx 76.92% <0.00%> (ø)
js/packages/components/permissions/Permission.tsx 75.00% <ø> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@clegirar clegirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good for the rest, you also have to regenerate the snapshots (yarn test -u) 👍

js/e2e-tests/README.md Outdated Show resolved Hide resolved
@clegirar clegirar force-pushed the chore/implem-new-e2e-tests branch 2 times, most recently from b31d0ff to 00f9fc5 Compare January 10, 2023 14:03
…for test purposes

Signed-off-by: Lucas De Curtis <lucas.de-curtis@epitech.eu>
Signed-off-by: Lucas De Curtis <lucas.de-curtis@epitech.eu>
Signed-off-by: Lucas De Curtis <lucas.de-curtis@epitech.eu>
Signed-off-by: Lucas De Curtis <lucas.de-curtis@epitech.eu>
Signed-off-by: Lucas De Curtis <lucas.de-curtis@epitech.eu>
Signed-off-by: Lucas De Curtis <lucas.de-curtis@epitech.eu>
@clegirar clegirar force-pushed the chore/implem-new-e2e-tests branch 7 times, most recently from 9e500eb to d8f073f Compare January 18, 2023 14:18
Signed-off-by: clegirar <clemntgirard@gmail.com>
@jefft0
Copy link
Collaborator

jefft0 commented Apr 25, 2023

Hello @lucasdc99 . We have an issue with the e2e tests on the CI server, so for the moment we don't run these tests. So, we will put this issue on the "backlog" and return to it when we start running e2e tests again. Does that sound good?

@jefft0 jefft0 added backlog more info needed Waiting for a response and removed chore backlog more info needed Waiting for a response labels Apr 25, 2023
@jefft0 jefft0 marked this pull request as draft August 7, 2023 12:57
@jefft0 jefft0 removed the backlog label Aug 7, 2023
@jefft0
Copy link
Collaborator

jefft0 commented Aug 7, 2023

Changed to Draft and removed backlog label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants