Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - publish grpc-bridge package #3985

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Mar 20, 2022

No description provided.

@n0izn0iz n0izn0iz self-assigned this Mar 20, 2022
@n0izn0iz n0izn0iz requested a review from a team as a code owner March 20, 2022 08:22
@trafico-bot trafico-bot bot added the 🚧 WIP label Mar 20, 2022
@n0izn0iz n0izn0iz marked this pull request as draft March 20, 2022 08:22
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #3985 (486a86b) into master (22e2489) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3985      +/-   ##
==========================================
+ Coverage   26.42%   26.47%   +0.04%     
==========================================
  Files         418      416       -2     
  Lines       33883    33751     -132     
  Branches     2099     2095       -4     
==========================================
- Hits         8954     8934      -20     
+ Misses      23794    23677     -117     
- Partials     1135     1140       +5     
Flag Coverage Δ
go.unittests 31.57% <ø> (+0.09%) ⬆️
js.unittests 11.48% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/packages/grpc-bridge/rpc/utils.ts 55.55% <ø> (+2.22%) ⬆️
go/pkg/bertyprotocol/api_event.go 47.88% <0.00%> (-3.53%) ⬇️
go/pkg/bertymessenger/service.go 38.35% <0.00%> (-2.02%) ⬇️
...nal/multipeer-connectivity-driver/bridge_darwin.go
go/internal/ble-driver/bridge_darwin.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e2489...486a86b. Read the comment docs.

@n0izn0iz n0izn0iz force-pushed the publish-js-grpc-bridge branch 2 times, most recently from 330cd46 to 09ecc8f Compare March 20, 2022 13:15
@n0izn0iz n0izn0iz force-pushed the publish-js-grpc-bridge branch 6 times, most recently from b7936f0 to 5b2f046 Compare March 30, 2022 07:48
Signed-off-by: Norman Meier <norman@berty.tech>
@jefft0 jefft0 removed the request for review from a team April 19, 2023 08:31
@jefft0 jefft0 removed the 🚧 WIP label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants