fs.rmdirSync() deprecated, use rmSync() #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: puppeteer-extra
Niek
approved these changes
Jun 16, 2021
|
LGTM, test failure seems unrelated, I'd rebase/re-run it. |
|
Apparently that won't fix the issues some windows users are experiencing: fs.rm(this._userDataDir, { recursive: true, force: true }, console.log)works on the other hand - closing this PR in favor of a new one with an async method. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get this warning from puppeteer-extra-plugin-user-data-dir:
(node:52638) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead (Use `node --trace-deprecation ...` to show where the warning was created)Swaps
fse.rmdirSync()withfse.rmSync(), which has identical behavior (both throw error when dir does not exist, both recursively remove subdirectories and files), successfully eliminates warning.