Fix MSRV & Windows clippy warning #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping @estokes @berkowski. Any feedback on this PR? |
|
Sorry, been busy lately I'll look at this soon |
This is needed as nix v0.26.0 raised its MSRV to 1.56.1. For more information please see the changelog: https://github.com/nix-rust/nix/blob/master/CHANGELOG.md#0260---2022-11-29 Or the corresponding PR: nix-rust/nix#1792 Signed-off-by: Richard Leitner <dev@g0hl1n.net>
This fixes following clippy warning:
Error: --> src\lib.rs:605:31
|
605 | let handle = unsafe { mem::transmute(handle) };
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D clippy::useless-transmute` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
Signed-off-by: Richard Leitner <dev@g0hl1n.net>
This is needed as env_logger v0.10.0 raised its MSRV to 1.60.0. For more
information please see the corresponding commit or PR:
rust-cli/env_logger@660cf7f
rust-cli/env_logger#248
Signed-off-by: Richard Leitner <dev@g0hl1n.net>
g0hl1n
force-pushed
the
g0hl1n_update-nix
branch
from
35e3d54
to
de66b35
Compare
g0hl1n
changed the title
|
Adapted the PR to current master. (dropped the dependency updates). |
|
Friendly ping @estokes @berkowski. Any feedback on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all dependencies to their latest version. Namely this is:
Furthermore bump the MSRV to 1.60.0 as this is required by env_logger v0.10.0 (see rust-cli/env_logger@660cf7f).