Use issubclass instead of isinstance to compare SourceGenerator in to_source #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berkerpeksag
reviewed
Dec 7, 2019
|
Should I make a new section (0.9.0) in the changelog for the release note? |
Yes, that would be great! Actually, we can even make it 0.8.1 for now. |
|
BTW, I just merged a PR that adds a new section for 0.8.1. You can now rebase your branch and add a new entry for this PR. |
berkerpeksag
approved these changes
Dec 8, 2019
|
Thank you! |
isidentical
pushed a commit
to isidentical/astor
that referenced
this pull request
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is just a bug. If
source_generator_classis a class, thenisinstanceis not appropriate since it's a class, not a class instance/object.