Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix packaging for setuptools>=41.4 #163

Merged
merged 1 commit into from Dec 7, 2019
Merged

Fix packaging for setuptools>=41.4 #163

merged 1 commit into from Dec 7, 2019

Conversation

jonringer
Copy link
Contributor

setup(**config['options']) is no longer valid, see #162 for error

closes #162

isidentical
isidentical reviewed Oct 18, 2019
View reviewed changes
astor/__init__.py Outdated Show resolved Hide resolved
berkerpeksag
berkerpeksag reviewed Oct 18, 2019
View reviewed changes
Copy link
Owner

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spending time to improve astor!

astor/__init__.py Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor Author

jonringer commented Oct 22, 2019 •
edited

bump @berkerpeksag @isidentical

@mukkid
Copy link

mukkid commented Oct 24, 2019

What is the status of this PR? @jonringer @berkerpeksag

@jonringer
Copy link
Contributor Author

it's ready to merge from my standpoint, and passes CI

@jonringer
Copy link
Contributor Author

had to modify the MANIFEST so that it exported the VERSION file when building a distribution, otherwise it would fail to open when installed

@priv-kweihmann priv-kweihmann mentioned this pull request Nov 4, 2019
Closed
priv-kweihmann added a commit to priv-kweihmann/meta-sca that referenced this pull request Nov 4, 2019
@priv-kweihmann
Fix compile issue with python-astor
173dfc1 
- Temporarily using not-merged pull request from
  project.
  see berkerpeksag/astor#163

Closes #416
priv-kweihmann added a commit to priv-kweihmann/meta-sca that referenced this pull request Nov 4, 2019
@priv-kweihmann
Fix compile issue with python-astor
2e6427a 
- Temporarily using not-merged pull request from
  project.
  see berkerpeksag/astor#163

Closes #416
bryteise
bryteise reviewed Nov 8, 2019
View reviewed changes
astor/__init__.py Outdated Show resolved Hide resolved
@jonringer jonringer force-pushed the fix-packaging branch 2 times, most recently from 660b9a8 to 3b857d3 Compare November 8, 2019 00:38
@jonringer
Copy link
Contributor Author

looks like i had had a stale branch on my other computer, had to re-apply the Path -> os.path changes.

@larstiq
Copy link

larstiq commented Nov 9, 2019

Looks good to me fwiw. Are there co-maintainers to take this forward if @berkerpeksag doesn't have time?

algitbot pushed a commit to alpinelinux/aports that referenced this pull request Nov 14, 2019
@ncopa
testing/py3-astor: fix packaging with setuptools>=41.4
b74c962 
patch from berkerpeksag/astor#163
@Flamefire Flamefire mentioned this pull request Nov 18, 2019
Closed
@jonringer
Copy link
Contributor Author

bump

@paulbors
Copy link

paulbors commented Dec 1, 2019

Please merge this fix in.

@berkerpeksag berkerpeksag merged commit 2159cfe into berkerpeksag:master Dec 7, 2019
@jonringer jonringer deleted the fix-packaging branch December 7, 2019 22:53
@berkerpeksag
Copy link
Owner

Thanks for the PR and sorry for my late response! I've been dealing with a lot of $LIFE stuff lately. I'll add a note to changelog and release 0.8.1 hopefully tomorrow.

@jonringer
Copy link
Contributor Author

@berkerpeksag I completely understand, :)

isidentical pushed a commit to isidentical/astor that referenced this pull request Dec 9, 2019
@jonringer @isidentical
Fix packaging for setuptools>=41.4 (berkerpeksag#163)
0a0b8a9 
Fixes berkerpeksag#162
@berkerpeksag
Copy link
Owner

0.8.1 is now published on PyPI: https://pypi.org/project/astor/0.8.1/

@jonringer jonringer mentioned this pull request Dec 10, 2019
Closed
10 tasks
thebaptiste added a commit to metwork-framework/mfextaddon_python3_ia that referenced this pull request Nov 25, 2020
@thebaptiste
build: upgrade astor to fix build with setuptools >= 41.4
d21269e 
(see berkerpeksag/astor#163)
@thebaptiste thebaptiste mentioned this pull request Nov 25, 2020
Merged
mergify bot pushed a commit to metwork-framework/mfextaddon_python3_ia that referenced this pull request Nov 26, 2020
@thebaptiste
build: upgrade astor to fix build with setuptools >= 41.4 (#50)
d83a7ae 
(see berkerpeksag/astor#163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryteise bryteise bryteise left review comments

@isidentical isidentical isidentical left review comments

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to install with setuptools==41.4.0
7 participants
@jonringer @mukkid @larstiq @paulbors @berkerpeksag @bryteise @isidentical