fix: Path issues with pip modules #4256
Open
+11
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wanted behavior when other bentofiles are on the system PATH This is especially evident when trying to use bentoml cli on python folders that are also pip modules see bentoml#4217
parano
reviewed
Nov 3, 2023
| @@ -172,7 +169,7 @@ def recover_standalone_env_change(): | |||
| object.__setattr__(instance, "_import_str", f"{module_name}:{attrs_str}") | |||
| return instance | |||
| except ImportServiceError: | |||
| if sys_path_modified and working_dir: | |||
| if working_dir: | |||
There was a problem hiding this comment.
we probably don't need this check neither now?
There was a problem hiding this comment.
I think this check is ensuring that if the assignment fails it doesn't try to remove None.
There was a problem hiding this comment.
Make sense, I'd suggest we move the working_dir assignment L75-81 out of the try block and remove this if working_dir check as well
There was a problem hiding this comment.
@sauyon made a quick patch, could you help take a look?
|
we probably should note the side effect of doing this here
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always prepend current bentofile directory to system path to avoid unwanted behavior when other bentofiles are on the system PATH
This is especially evident when trying to use bentoml cli on python folders that are also pip modules see #4217