Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use httpx for testing #4227

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: use httpx for testing #4227

wants to merge 4 commits into from

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented Oct 10, 2023

No description provided.

@sauyon sauyon requested a review from a team as a code owner October 10, 2023 02:18
@sauyon sauyon requested review from frostming and removed request for a team October 10, 2023 02:18
@pep8speaks
Copy link

Hello @sauyon! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 40:80: E501 line too long (80 > 79 characters)

Line 180:80: E501 line too long (170 > 79 characters)
Line 190:80: E501 line too long (170 > 79 characters)
Line 200:80: E501 line too long (84 > 79 characters)

sauyon and others added 2 commits October 9, 2023 21:05
@sauyon
add httpx dependency
b05de32
@sauyon @judahrand
use httpx for tests
efb68ec 
Co-Authored-By: Judah Rand <17158624+judahrand@users.noreply.github.com>
@sauyon sauyon marked this pull request as draft October 10, 2023 04:38
@aarnphm aarnphm marked this pull request as ready for review October 22, 2023 18:49
@Haivilo Haivilo mentioned this pull request Dec 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium left review comments

@frostming frostming Awaiting requested review from frostming frostming is a code owner automatically assigned from bentoml/bentoml-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sauyon @pep8speaks @natsukium @aarnphm