Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud): use httpx for cloud clients #4224

Open
wants to merge 2 commits into
base: 1.2
Choose a base branch
from

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented Oct 10, 2023

No description provided.

@sauyon sauyon requested a review from a team as a code owner October 10, 2023 01:37
@sauyon sauyon requested review from parano and removed request for a team October 10, 2023 01:37
@pep8speaks
Copy link

pep8speaks commented Oct 10, 2023

Hello @sauyon! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 325:80: E501 line too long (87 > 79 characters)
Line 518:80: E501 line too long (81 > 79 characters)
Line 520:80: E501 line too long (88 > 79 characters)
Line 768:80: E501 line too long (87 > 79 characters)
Line 966:80: E501 line too long (84 > 79 characters)

Line 506:80: E501 line too long (81 > 79 characters)
Line 508:80: E501 line too long (88 > 79 characters)
Line 750:80: E501 line too long (87 > 79 characters)
Line 946:80: E501 line too long (84 > 79 characters)

Comment last updated at 2023-10-10 01:55:08 UTC

@sauyon sauyon force-pushed the httpx-bcloud branch 4 times, most recently from f6444f0 to 4e77d01 Compare October 10, 2023 01:55
@sauyon sauyon marked this pull request as draft October 10, 2023 02:19
@sauyon sauyon marked this pull request as ready for review October 10, 2023 03:58
sauyon and others added 2 commits October 9, 2023 21:05
Co-Authored-By: Judah Rand <17158624+judahrand@users.noreply.github.com>
@aarnphm
Copy link
Member

aarnphm commented Nov 9, 2023

@xianml can you take a look at these when you have bandwidth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants