Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial rust implementation #3891

Closed
wants to merge 4 commits into from
Closed

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented May 25, 2023

@sauyon sauyon requested a review from a team as a code owner May 25, 2023 06:31
@sauyon sauyon requested review from larme and removed request for a team May 25, 2023 06:31
@sauyon sauyon force-pushed the maturin branch 2 times, most recently from 0c19aaa to efa8c10 Compare May 25, 2023 06:33
@aarnphm
Copy link
Member

aarnphm commented May 25, 2023

Love this very much. But probably we can merge this in once everyone else PR is in, since this essentially move the project structure to rust implementation.

@sauyon
Copy link
Contributor Author

sauyon commented May 25, 2023

Actually got should handle the merge just fine.

But I don't know whether we actually want to merge this anytime soon, anyway, probably want to confirm everything's working.

gRPC tests are failing, for example... ;)

@sauyon
Copy link
Contributor Author

sauyon commented May 25, 2023

After that gets fixed I should factor out both the tag and exception changes, I think.

@sauyon sauyon force-pushed the maturin branch 2 times, most recently from 9d26213 to 254550f Compare June 7, 2023 02:24
@sauyon sauyon force-pushed the maturin branch 3 times, most recently from 21ce02f to b92f9e4 Compare August 29, 2023 03:20
@aarnphm aarnphm mentioned this pull request Aug 29, 2023
5 tasks
@sauyon
Copy link
Contributor Author

sauyon commented Aug 29, 2023

Closing as discussed.

@sauyon sauyon closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants