Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add context manager support for bentoml.client #3402

Merged
merged 2 commits into from
Jan 13, 2023
Merged

feat: add context manager support for bentoml.client #3402

merged 2 commits into from
Jan 13, 2023

Commits on Jan 13, 2023

  1. feat: bentoml.client add context manager support. (bentoml#3288) 

    - implments `__enter__`,`__exit__`,`__aenter__`and `__aexit__`

A dummy implementation is added to support to context protocol as it is
required for the 'with' statement.

The implementation of exit method is empty as client does not have
any persistent connection, each api call is processed in a separate
aio.http session.
    @y1450
    y1450 committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    39fe307 View commit details
    Browse the repository at this point in the history

  2. refactor: add type annotations for __exit__ and __aexit__

    @y1450
    y1450 committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    cc76526 View commit details
    Browse the repository at this point in the history