Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove whitespaces in migration guides #3185

Merged
merged 2 commits into from Nov 3, 2022
Merged

docs: remove whitespaces in migration guides #3185

merged 2 commits into from Nov 3, 2022

Conversation

wellshs
Copy link
Contributor

@wellshs wellshs commented Nov 3, 2022

What does this PR address?

Thanks for good open source project!

I have been using bentoml since version 0.13.1, I checked the migration guide once I heard the news that version 1 was released this time.
While following the migration guide, I've experienced that bentofile.yaml's indent is wrong and doesn't work, so I'm trying to contribute to my favorite open source, although it's minor.

Before submitting:

@wellshs wellshs requested a review from a team as a code owner November 3, 2022 11:47
@wellshs wellshs requested review from sauyon and removed request for a team November 3, 2022 11:47
Copy link
Member

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@aarnphm aarnphm changed the title docs: Fix migration.rst docs: remove whitespaces in migration guides Nov 3, 2022
@aarnphm aarnphm merged commit 0469d8a into bentoml:main Nov 3, 2022
@wellshs wellshs deleted the fix_migration_guide branch November 4, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants