Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazy check for stubs via path when install local wheels #3180

Merged
merged 1 commit into from Nov 3, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Nov 2, 2022

Fix checking grpc availability when BENTOML_LOCAL_BUNDLE_BUILD is specified

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

@aarnphm aarnphm requested a review from a team as a code owner November 2, 2022 20:24
@aarnphm aarnphm requested review from ssheng and removed request for a team November 2, 2022 20:24
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #3180 (87d185f) into main (0e8b7b8) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3180   +/-   ##
=======================================
  Coverage   21.69%   21.70%           
=======================================
  Files         101      101           
  Lines        9735     9732    -3     
  Branches     1691     1692    +1     
=======================================
  Hits         2112     2112           
+ Misses       7575     7572    -3     
  Partials       48       48           
Impacted Files Coverage Δ
...c/bentoml/_internal/bento/build_dev_bentoml_whl.py 31.42% <0.00%> (+2.48%) ⬆️

@aarnphm aarnphm changed the title fix: lazy check for local wheel installation via path fix: lazy check for stubs via path when install local wheels Nov 2, 2022
@aarnphm aarnphm enabled auto-merge (squash) November 2, 2022 20:51
@aarnphm aarnphm merged commit f238251 into bentoml:main Nov 3, 2022
@aarnphm aarnphm deleted the fix/lazy-check-local-wheel branch November 3, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants