Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: type checking hack #3162

Merged
merged 2 commits into from Oct 30, 2022
Merged

style: type checking hack #3162

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02c649d
style: hack around type checking
aarnphm Oct 30, 2022
cbd0f44
chore: rename to ListStr
aarnphm Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/bentoml/_internal/bento/build_config.py
View file
Open in desktop
Expand Up @@ -284,6 +284,12 @@ def conda_dependencies_validator(
)


if TYPE_CHECKING:
L: t.TypeAlias = list[str]
aarnphm marked this conversation as resolved.
Show resolved Hide resolved
else:
L = list
aarnphm marked this conversation as resolved.
Show resolved Hide resolved


@attr.frozen
class CondaOptions:

Expand All @@ -295,14 +301,14 @@ class CondaOptions:
environment_yml: t.Optional[str] = None
channels: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(L)),
aarnphm marked this conversation as resolved.
Show resolved Hide resolved
)
dependencies: t.Optional[DependencyType] = attr.field(
default=None, validator=attr.validators.optional(conda_dependencies_validator)
)
pip: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(L)),
aarnphm marked this conversation as resolved.
Show resolved Hide resolved
)

def __attrs_post_init__(self):
Expand Down Expand Up @@ -402,7 +408,7 @@ class PythonOptions:
)
packages: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(L)),
aarnphm marked this conversation as resolved.
Show resolved Hide resolved
)
lock_packages: t.Optional[bool] = attr.field(
default=None,
Expand All @@ -418,23 +424,23 @@ class PythonOptions:
)
trusted_host: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(L)),
aarnphm marked this conversation as resolved.
Show resolved Hide resolved
)
find_links: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(L)),
aarnphm marked this conversation as resolved.
Show resolved Hide resolved
)
extra_index_url: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(L)),
aarnphm marked this conversation as resolved.
Show resolved Hide resolved
)
pip_args: t.Optional[str] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(str)),
)
wheels: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(L)),
aarnphm marked this conversation as resolved.
Show resolved Hide resolved
)

def __attrs_post_init__(self):
Expand Down