Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky CI #3083

Merged
merged 13 commits into from Oct 13, 2022
Merged

fix: flaky CI #3083

merged 13 commits into from Oct 13, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Oct 10, 2022

This PR ensures interceptors are registered correctly instead of MK

@aarnphm aarnphm requested a review from a team as a code owner October 10, 2022 06:10
@aarnphm aarnphm requested review from ssheng and sauyon and removed request for a team October 10, 2022 06:10
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #3083 (b80f95e) into main (81dd8de) will increase coverage by 3.29%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
+ Coverage   58.59%   61.88%   +3.29%     
==========================================
  Files         103      123      +20     
  Lines       10162    10951     +789     
  Branches     1747     1876     +129     
==========================================
+ Hits         5954     6777     +823     
+ Misses       3817     3734      -83     
- Partials      391      440      +49     
Impacted Files Coverage Δ
src/bentoml/grpc/types.py 0.00% <ø> (ø)
src/bentoml/_internal/server/grpc/servicer.py 54.87% <40.00%> (+0.55%) ⬆️
src/bentoml/_internal/server/grpc/server.py 35.64% <100.00%> (-0.64%) ⬇️
src/bentoml/_internal/service/service.py 85.00% <100.00%> (ø)
src/bentoml/grpc/interceptors/access.py 95.34% <100.00%> (ø)
src/bentoml/grpc/interceptors/opentelemetry.py 77.61% <100.00%> (ø)
src/bentoml/grpc/interceptors/prometheus.py 96.15% <100.00%> (ø)
src/bentoml/grpc/utils/__init__.py 88.88% <100.00%> (ø)
src/bentoml/__init__.py 0.00% <0.00%> (ø)
src/bentoml/torchscript.py 55.55% <0.00%> (ø)
... and 35 more

@bojiang
Copy link
Member

bojiang commented Oct 12, 2022

It seems that the e2e get unstable after #2984

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@sauyon sauyon merged commit 64fe85d into bentoml:main Oct 13, 2022
@aarnphm aarnphm deleted the fix/flaky-ci branch October 13, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants