Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update links #3040

Merged
merged 1 commit into from Sep 27, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions docs/source/guides/grpc.rst
Expand Up @@ -73,7 +73,7 @@ Client Implementation

.. note::

All of the following client implementations are :github:`available on GitHub <bentoml/BentoML/tree/main/docs/source/guides/snippets/grpc/>`.
All of the following client implementations are :github:`available on GitHub <bentoml/BentoML/tree/main/grpc-client/>`.

:raw-html:`<br />`

Expand Down Expand Up @@ -471,6 +471,10 @@ gRPC server:

:bdg-info:`Requirements:` Make sure to follow the :github:`instructions <grpc/grpc/blob/master/src/php/README.md>` to install ``grpc`` via either `pecl <https://pecl.php.net/>`_ or from source.

.. note::

You will also have to symlink the built C++ extension to the PHP extension directory for it to be loaded by PHP.

We will then use `bazel <bazel.build>`_, `composer <https://getcomposer.org/>`_ to build and run the client.

We will create our PHP client in the directory ``~/workspace/iris_php_client/``:
Expand Down Expand Up @@ -565,7 +569,7 @@ Then you can proceed to run the client scripts:

.. note::

See the :github:`instructions on GitHub <bentoml/BentoML/tree/main/docs/source/guides/snippets/grpc/README.md>` for working C++ client.
See the :github:`instructions on GitHub <bentoml/BentoML/tree/main/grpc-client/README.md>` for working C++ client.

.. tab-item:: Java
:sync: java
Expand All @@ -591,7 +595,7 @@ Then you can proceed to run the client scripts:

.. note::

See the :github:`instructions on GitHub <bentoml/BentoML/tree/main/docs/source/guides/snippets/grpc/README.md>` for working Java client.
See the :github:`instructions on GitHub <bentoml/BentoML/tree/main/grpc-client/README.md>` for working Java client.

.. tab-item:: Kotlin
:sync: kotlin
Expand All @@ -617,7 +621,7 @@ Then you can proceed to run the client scripts:

.. note::

See the :github:`instructions on GitHub <bentoml/BentoML/tree/main/docs/source/guides/snippets/grpc/README.md>` for working Kotlin client.
See the :github:`instructions on GitHub <bentoml/BentoML/tree/main/grpc-client/README.md>` for working Kotlin client.

.. tab-item:: Node.js
:sync: nodejs
Expand Down