Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): receive requests before cork #2996

Merged
merged 2 commits into from Sep 16, 2022
Merged

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Sep 14, 2022

What does this PR address?

Fixes #(issue)

Before submitting:

Who can help review?

Feel free to tag members/contributors who can help review your PR.

@ssheng
Copy link
Collaborator

ssheng commented Sep 16, 2022

Please rebase. @bojiang

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #2996 (042b14a) into main (532f5e1) will decrease coverage by 4.81%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2996      +/-   ##
==========================================
- Coverage   69.04%   64.23%   -4.82%     
==========================================
  Files         122      114       -8     
  Lines       10253    10987     +734     
==========================================
- Hits         7079     7057      -22     
- Misses       3174     3930     +756     
Impacted Files Coverage Δ
bentoml/_internal/marshal/dispatcher.py 83.54% <ø> (ø)
bentoml/_internal/server/runner_app.py 91.36% <95.83%> (-4.64%) ⬇️
bentoml/_internal/frameworks/torchscript.py 0.00% <0.00%> (-96.00%) ⬇️
bentoml/_internal/frameworks/common/pytorch.py 0.00% <0.00%> (-72.64%) ⬇️
bentoml/_internal/io_descriptors/base.py 61.53% <0.00%> (-29.09%) ⬇️
bentoml/_internal/io_descriptors/numpy.py 70.43% <0.00%> (-26.69%) ⬇️
bentoml/_internal/io_descriptors/file.py 64.48% <0.00%> (-26.56%) ⬇️
bentoml/_internal/io_descriptors/image.py 58.11% <0.00%> (-25.22%) ⬇️
bentoml/_internal/io_descriptors/json.py 66.17% <0.00%> (-23.08%) ⬇️
bentoml/_internal/service/service.py 79.23% <0.00%> (-17.48%) ⬇️
... and 98 more

@bojiang
Copy link
Member Author

bojiang commented Sep 16, 2022

@ssheng updated

@bojiang bojiang marked this pull request as ready for review September 16, 2022 08:42
@bojiang bojiang requested a review from a team as a code owner September 16, 2022 08:42
@bojiang bojiang requested review from jjmachan and removed request for a team September 16, 2022 08:42
@ssheng ssheng merged commit bf1e8b5 into bentoml:main Sep 16, 2022
@bojiang bojiang deleted the fix-tracing branch September 16, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants