feat(cli): show full tracebacks in debug mode #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
previously approved these changes
Sep 12, 2022
aarnphm
force-pushed
the
debug-tracebacks
branch
from
59578d2
to
0535e19
Compare
aarnphm
approved these changes
Sep 13, 2022
aarnphm
changed the title
sauyon
added a commit
to sauyon/BentoML
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot we set debug mode globally and I didn't need to grab the value of the flag from the click arguments, so this was actually pretty simple 馃槄
Should resolve #2966 @smidm, if you want to confirm.