EXPERIMENTAL[grpc]: synonymous configuration fields #2980

aarnphm · 2022-09-12T04:21:03Z

Address #2986

This PR address some tests followup as well as some configuration refactor to be consistent with correct exporter field

This PR will also introduce tests related to gRPC tracing interceptor

Depends on #2808 and will rebase to main once #2808 is merged.

pep8speaks · 2022-09-12T04:22:07Z

Hello @aarnphm, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2022-09-13 11:54:03 UTC

codecov · 2022-09-12T04:26:50Z

Codecov Report

Merging #2980 (df37888) into main (926b613) will decrease coverage by 0.01%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##             main    #2980      +/-   ##
==========================================
- Coverage   67.96%   67.94%   -0.02%     
==========================================
  Files         113      113              
  Lines       10887    10919      +32     
  Branches     1908     1947      +39     
==========================================
+ Hits         7399     7419      +20     
- Misses       3047     3062      +15     
+ Partials      441      438       -3

Impacted Files	Coverage Δ
bentoml/_internal/configuration/containers.py	`74.21% <63.63%> (+1.77%)`	⬆️
bentoml/grpc/interceptors/access.py	`93.02% <0.00%> (-2.33%)`	⬇️
bentoml/grpc/interceptors/prometheus.py	`94.23% <0.00%> (-1.93%)`	⬇️
bentoml/grpc/interceptors/opentelemetry.py	`76.11% <0.00%> (-1.50%)`	⬇️
bentoml/_internal/utils/analytics/usage_stats.py	`94.62% <0.00%> (-1.08%)`	⬇️
bentoml/_internal/utils/__init__.py	`67.28% <0.00%> (-0.75%)`	⬇️
bentoml/_internal/service/loader.py	`72.59% <0.00%> (-0.75%)`	⬇️
bentoml/_internal/utils/telemetry.py	`84.00% <0.00%> (-0.62%)`	⬇️
bentoml/_internal/bento/pip_pkg.py	`0.00% <0.00%> (ø)`
bentoml/_internal/utils/benchmark.py	`0.00% <0.00%> (ø)`
... and 3 more

sauyon · 2022-09-12T21:59:23Z

bentoml/_internal/configuration/containers.py

+            # - tracing.jaeger.* -> tracing.jaeger.http.*
+            # - add tracing.jaeger.grpc.* with default values
+            # TODO: follow up versioning and deprecation generation.
+            v1_to_v2_migration(config_merger, override_config)


We should only call this if there's no version specified, i.e. it's a v1 config.

We need to figure out some way to enforce people to version their configs though.

I was thinking to have a version field

version: v1 ...

if no version is specified, then we default that to v1

sauyon · 2022-09-12T22:01:31Z

bentoml/_internal/configuration/containers.py

+            for key in ["cors", "max_request_size", "host", "port"]
+        )
+    # tracing compat
+    if "tracing" in override_config:


Maybe a utility function rename_field might be useful? e.g. rename_field(config, "zipkin.url", "zipkin.endpoint") or something? I think it would make this easier to read.

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

enable tracing tests for grpc Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm force-pushed the refactor/configuration branch from f6c0930 to 9c58784 Compare September 12, 2022 04:21

aarnphm force-pushed the refactor/configuration branch 2 times, most recently from e11f81c to 6b2d765 Compare September 12, 2022 21:52

aarnphm changed the title ~~refactor: synonymous configuration fields [DEPENDS ON #2808]~~ EXPERIMENTAL[grpc]: synonymous configuration fields Sep 12, 2022

aarnphm changed the base branch from main to grpc September 12, 2022 21:57

aarnphm marked this pull request as ready for review September 12, 2022 21:57

aarnphm requested a review from a team as a code owner September 12, 2022 21:57

aarnphm requested review from ssheng and removed request for a team September 12, 2022 21:57

aarnphm force-pushed the grpc branch from d6d0f79 to 07714fd Compare September 12, 2022 21:58

aarnphm requested a review from parano as a code owner September 12, 2022 21:58

aarnphm force-pushed the refactor/configuration branch 2 times, most recently from 2d1b5a5 to 5772b59 Compare September 12, 2022 22:03

aarnphm mentioned this pull request Sep 12, 2022

EXPERIMENTAL: gRPC support #2808

Merged

3 tasks

sauyon reviewed Sep 12, 2022

View reviewed changes

aarnphm force-pushed the grpc branch 5 times, most recently from b571593 to 1df6f6c Compare September 13, 2022 01:04

aarnphm force-pushed the refactor/configuration branch from 5772b59 to 18ae32a Compare September 13, 2022 01:06

aarnphm force-pushed the grpc branch from 1df6f6c to 5744fd1 Compare September 13, 2022 01:14

aarnphm force-pushed the refactor/configuration branch from 18ae32a to cb39b57 Compare September 13, 2022 01:15

aarnphm force-pushed the grpc branch 2 times, most recently from 86f7b3b to 5c7939e Compare September 13, 2022 06:24

aarnphm force-pushed the refactor/configuration branch from cb39b57 to 88cf2ac Compare September 13, 2022 06:25

aarnphm force-pushed the grpc branch from 5c7939e to 3184bc0 Compare September 13, 2022 06:35

aarnphm force-pushed the refactor/configuration branch from 88cf2ac to 0a16669 Compare September 13, 2022 06:35

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 17, 2022

chore(otel): remove otel setup (move to bentoml#2980)

8030044

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm force-pushed the refactor/configuration branch from 6c287fe to 7ef707a Compare September 17, 2022 11:52

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 17, 2022

chore(otel): remove otel setup (move to bentoml#2980)

3e0f9f8

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 18, 2022

chore(otel): remove otel setup (move to bentoml#2980)

5a27925

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 18, 2022

chore(otel): remove otel setup (move to bentoml#2980)

8485db9

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 18, 2022

chore(otel): remove otel setup (move to bentoml#2980)

c533a35

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 18, 2022

chore(otel): remove otel setup (move to bentoml#2980)

cce135d

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm force-pushed the refactor/configuration branch from 7ef707a to 4f8b279 Compare September 18, 2022 06:35

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 18, 2022

chore(otel): remove otel setup (move to bentoml#2980)

f78d80c

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm force-pushed the refactor/configuration branch from 4f8b279 to 5fd3d9e Compare September 18, 2022 08:35

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 18, 2022

chore(otel): remove otel setup (move to bentoml#2980)

2d3cd42

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm force-pushed the refactor/configuration branch from 5fd3d9e to 3aa0e88 Compare September 18, 2022 09:06

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 19, 2022

chore(otel): remove otel setup (move to bentoml#2980)

8cafd19

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm force-pushed the refactor/configuration branch from 3aa0e88 to 9a3d20f Compare September 19, 2022 05:50

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 20, 2022

chore(otel): remove otel setup (move to bentoml#2980)

cbb83ac

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 20, 2022

chore(otel): remove otel setup (move to bentoml#2980)

c31f00d

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 20, 2022

chore(otel): remove otel setup (move to bentoml#2980)

02f0cc2

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 20, 2022

chore(otel): remove otel setup (move to bentoml#2980)

1def8b5

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 20, 2022

chore(otel): remove otel setup (move to bentoml#2980)

dda4ccd

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm force-pushed the refactor/configuration branch from 9a3d20f to e56b70c Compare September 20, 2022 23:36

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 20, 2022

chore(otel): remove otel setup (move to bentoml#2980)

c7c53e6

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 21, 2022

chore(otel): remove otel setup (move to bentoml#2980)

735f2cb

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 27, 2022

chore(otel): remove otel setup (move to bentoml#2980)

b499fe4

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 27, 2022

chore(otel): remove otel setup (move to bentoml#2980)

e6709ac

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 27, 2022

chore(otel): remove otel setup (move to bentoml#2980)

ac438d7

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Sep 28, 2022

chore(otel): remove otel setup (move to bentoml#2980)

26c0753

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

feat: refactor configuration options for tracing

f783297

enable tracing tests for grpc Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm force-pushed the refactor/configuration branch from e56b70c to f783297 Compare September 29, 2022 19:24

chore: update migration for comments args

df37888

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

aarnphm closed this Sep 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EXPERIMENTAL[grpc]: synonymous configuration fields #2980

EXPERIMENTAL[grpc]: synonymous configuration fields #2980

aarnphm commented Sep 12, 2022 •

edited

pep8speaks commented Sep 12, 2022 •

edited

codecov bot commented Sep 12, 2022 •

edited

sauyon Sep 12, 2022

aarnphm Sep 12, 2022 •

edited

sauyon Sep 12, 2022

aarnphm Sep 12, 2022

EXPERIMENTAL[grpc]: synonymous configuration fields #2980

EXPERIMENTAL[grpc]: synonymous configuration fields #2980

Conversation

aarnphm commented Sep 12, 2022 • edited

pep8speaks commented Sep 12, 2022 • edited

Comment last updated at 2022-09-13 11:54:03 UTC

codecov bot commented Sep 12, 2022 • edited

Codecov Report

sauyon Sep 12, 2022

Choose a reason for hiding this comment

aarnphm Sep 12, 2022 • edited

Choose a reason for hiding this comment

sauyon Sep 12, 2022

Choose a reason for hiding this comment

aarnphm Sep 12, 2022

Choose a reason for hiding this comment

aarnphm commented Sep 12, 2022 •

edited

pep8speaks commented Sep 12, 2022 •

edited

codecov bot commented Sep 12, 2022 •

edited

aarnphm Sep 12, 2022 •

edited