docs: update wrong paths for disabling logs #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creativedutchmen
requested review from
aarnphm
and removed request for
a team
bojiang
approved these changes
Sep 8, 2022
aarnphm
approved these changes
Sep 8, 2022
aarnphm
changed the title
jiewpeng
pushed a commit
to jiewpeng/BentoML
that referenced
this pull request
Sep 12, 2022
YAML fields for disabling access logs on docs is not correct before. This PR address this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
In the docs on logging (https://docs.bentoml.org/en/latest/guides/logging.html#web-service-request-logging) it is incorrectly stated that the
loggingkey should be at the root path - it should be within theapi_serverkey instead.Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
@bojiang