feat: update variables in metric names as labels #2969
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
BentoML metrics name used to encode service names, runner names, and worker index etc, into the metric names. This practice however is not friendly to setting up dashboards in Prometheus and Grafana. This PR moves all variables parts in the metric names as labels and hardcode
bentoml
as the prefix. This PR also maintains backward compatibility by continue to produce metrics in the legacy format.Legacy metrics:
New metrics:
Both sets of the metrics will be supported until we can phase out the legacy one.
Fixes #2963
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
Feel free to tag members/contributors who can help review your PR.