Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): remove unused --no-trunc #2965

Merged
merged 2 commits into from Sep 3, 2022
Merged

Conversation

benjamintanweihao
Copy link
Contributor

What does this PR address?

Remove unused --no-trunc from bentoml models list and bentoml list.

Who can help review?

@aarnphm

@benjamintanweihao benjamintanweihao requested a review from a team as a code owner September 2, 2022 08:18
@benjamintanweihao benjamintanweihao requested review from ssheng and removed request for a team September 2, 2022 08:18
@aarnphm
Copy link
Member

aarnphm commented Sep 2, 2022

cc @parano abt this, but I vaguely remember we want ro impl this feature for using it in CI.

@parano
Copy link
Member

parano commented Sep 2, 2022

cc @parano abt this, but I vaguely remember we want ro impl this feature for using it in CI.

I think the json and yaml output type are more suitable for CI usage, this option can be removed now.

Thanks for the PR @benjamintanweihao!

@aarnphm aarnphm changed the title fix: remove unused --no-trunc from list commands chore(cli): remove unused --no-trunc Sep 3, 2022
@aarnphm aarnphm merged commit db31e42 into bentoml:main Sep 3, 2022
jiewpeng pushed a commit to jiewpeng/BentoML that referenced this pull request Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants