Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax regex for setting environment variables #2964

Merged
merged 1 commit into from Sep 7, 2022

Conversation

benjamintanweihao
Copy link
Contributor

What does this PR address?

This change allows for environment variables with dashes in them.

Before submitting:

Who can help review?

@aarnphm

This change allows for environment variables with dashes in them.
@benjamintanweihao benjamintanweihao requested a review from a team as a code owner September 2, 2022 07:23
@benjamintanweihao benjamintanweihao requested review from larme and removed request for a team September 2, 2022 07:23
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #2964 (b40c760) into main (f0e0bf0) will increase coverage by 0.89%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2964      +/-   ##
==========================================
+ Coverage   69.71%   70.60%   +0.89%     
==========================================
  Files         104      104              
  Lines        9538     9538              
==========================================
+ Hits         6649     6734      +85     
+ Misses       2889     2804      -85     
Impacted Files Coverage Δ
bentoml/_internal/bento/build_config.py 67.62% <0.00%> (ø)
bentoml/_internal/utils/__init__.py 77.25% <0.00%> (+0.47%) ⬆️
bentoml/_internal/runner/runner_handle/remote.py 88.54% <0.00%> (+3.12%) ⬆️
bentoml/_internal/utils/docker.py 68.96% <0.00%> (+34.48%) ⬆️
bentoml/_internal/utils/buildx.py 48.29% <0.00%> (+48.29%) ⬆️

Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@sauyon sauyon merged commit c075e12 into bentoml:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants