Skip to content

fix: fix context parameter for multi-input IO descriptors #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented Aug 29, 2022

I should probably write a test for the multipart descriptor...

@sauyon sauyon requested a review from a team as a code owner August 29, 2022 13:40
@sauyon sauyon requested review from jjmachan and removed request for a team August 29, 2022 13:40
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #2948 (9b376db) into main (83d8a30) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2948   +/-   ##
=======================================
  Coverage   70.60%   70.60%           
=======================================
  Files         104      104           
  Lines        9538     9538           
=======================================
  Hits         6734     6734           
  Misses       2804     2804           
Impacted Files Coverage Δ
bentoml/_internal/service/inference_api.py 70.00% <100.00%> (ø)

@sauyon sauyon force-pushed the fix-multipart-context branch from edd9653 to e952a98 Compare August 29, 2022 13:50

Verified

This commit was signed with the committer’s verified signature.
ti-mo Timo Beckers
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test would be very nice

@ssheng ssheng merged commit 43c4eae into bentoml:main Aug 31, 2022
@aarnphm aarnphm deleted the fix-multipart-context branch August 31, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants