New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(runner): add multiple output support #2912
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
- Coverage 70.60% 68.99% -1.61%
==========================================
Files 104 122 +18
Lines 9538 10145 +607
==========================================
+ Hits 6734 7000 +266
- Misses 2804 3145 +341
|
e54024f
to
73886e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to add a performance tests for this specific feature? I believe that having a regression test for this would be helpful so that we don't introduce features in the future that slow down the request?
just test this pr without noticeable performance difference. I'm making a script to manually launch a performance test but it needs some time to finish |
A think a script that run separately for this PR is good enough. I can follow up with a PR into a CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 😄
## What does this PR address? <!-- Thanks for sending a pull request! Congrats for making it this far! Here's a 🍱 for you. There are still a few steps ahead. Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code review. Name your Pull Request with one of the following prefixes, e.g. "feat: add support for PyTorch", to indicate the type of changes proposed. This is based on the [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/#summary). - feat: (new feature for the user, not a new feature for build script) - fix: (bug fix for the user, not a fix to a build script) - docs: (changes to the documentation) - style: (formatting, missing semicolons, etc; no production code change) - refactor: (refactoring production code, eg. renaming a variable) - perf: (code changes that improve performance) - test: (adding missing tests, refactoring tests; no production code change) - chore: (updating grunt tasks etc; no production code change) - build: (changes that affect the build system or external dependencies) - ci: (changes to configuration files and scripts) - revert: (reverts a previous commit) Describe your changes in detail. Attach screenshots here if appropriate. Once you're done with this, someone from BentoML team or community member will help review your PR (see "Who can help review?" section for potential reviewers.). If no one has reviewed your PR after a week have passed, don't hesitate to post a new comment and ping @-the same person. Notifications sometimes get lost 🥲. --> <!-- Remove if not applicable --> Fixes #(issue) ## Before submitting: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!--- If you plan to update documentation or tests in follow-up, please note --> - [ ] Does the Pull Request follow [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/#summary) naming? Here are [GitHub's guide](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request) on how to create a pull request. - [ ] Does the code follow BentoML's code style, both `make format` and `make lint` script have passed ([instructions](https://github.com/bentoml/BentoML/blob/main/DEVELOPMENT.md#style-check-auto-formatting-type-checking))? - [ ] Did you read through [contribution guidelines](https://github.com/bentoml/BentoML/blob/main/CONTRIBUTING.md#ways-to-contribute) and follow [development guidelines](https://github.com/bentoml/BentoML/blob/main/DEVELOPMENT.md#start-developing)? - [ ] Did your changes require updates to the documentation? Have you updated those accordingly? Here are [documentation guidelines](https://github.com/bentoml/BentoML/tree/main/docs) and [tips on writting docs](https://github.com/bentoml/BentoML/tree/main/docs#writing-documentation). - [ ] Did you write tests to cover your changes? ## Who can help review? Feel free to tag members/contributors who can help review your PR. <!-- Feel free to ping any of the BentoML members for help on your issue, but don't ping more than three people 😊. If you know how to use git blame, that is probably the easiest way. Team members that you can ping: - @parano - @yubozhao - @bojiang - @ssheng - @aarnphm - @sauyon - @larme - @yetone - @jjmachan -->
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
Feel free to tag members/contributors who can help review your PR.