Skip to content

Commit

Permalink
style: type checking hack (#3162)
Browse files Browse the repository at this point in the history
  • Loading branch information
aarnphm committed Oct 30, 2022
1 parent 871ca1f commit 607cca2
Showing 1 changed file with 13 additions and 7 deletions.
20 changes: 13 additions & 7 deletions src/bentoml/_internal/bento/build_config.py
Expand Up @@ -284,6 +284,12 @@ def conda_dependencies_validator(
)


if TYPE_CHECKING:
ListStr: t.TypeAlias = list[str]
else:
ListStr = list


@attr.frozen
class CondaOptions:

Expand All @@ -295,14 +301,14 @@ class CondaOptions:
environment_yml: t.Optional[str] = None
channels: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(ListStr)),
)
dependencies: t.Optional[DependencyType] = attr.field(
default=None, validator=attr.validators.optional(conda_dependencies_validator)
)
pip: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(ListStr)),
)

def __attrs_post_init__(self):
Expand Down Expand Up @@ -402,7 +408,7 @@ class PythonOptions:
)
packages: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(ListStr)),
)
lock_packages: t.Optional[bool] = attr.field(
default=None,
Expand All @@ -418,23 +424,23 @@ class PythonOptions:
)
trusted_host: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(ListStr)),
)
find_links: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(ListStr)),
)
extra_index_url: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(ListStr)),
)
pip_args: t.Optional[str] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(str)),
)
wheels: t.Optional[t.List[str]] = attr.field(
default=None,
validator=attr.validators.optional(attr.validators.instance_of(list)),
validator=attr.validators.optional(attr.validators.instance_of(ListStr)),
)

def __attrs_post_init__(self):
Expand Down

0 comments on commit 607cca2

Please sign in to comment.