Skip to content

Commit

Permalink
chore: update migration for comments args
Browse files Browse the repository at this point in the history
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
  • Loading branch information
aarnphm committed Sep 29, 2022
1 parent 55f6626 commit 2e1ba1f
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions bentoml/_internal/configuration/containers.py
Expand Up @@ -379,6 +379,13 @@ def __init__(
raise BentoMLConfigException(
f"Failed to parse config options from the env var: {e}. \n *** Note: You can use '\"' to quote the key if it contains special characters. ***"
) from None
# v1 -> v2 changes follow:
# - api_server.[max_request_size|cors|port|host] -> api_server.http.$^
# - tracing.jaeger.* -> tracing.jaeger.http.*
# - add tracing.jaeger.grpc.* with default values
# TODO: follow up versioning and deprecation generation.
v1_to_v2_migration(config_merger, override_config)

config_merger.merge(self.config, override_config)

if override_config_file is not None or override_config_values is not None:
Expand Down

0 comments on commit 2e1ba1f

Please sign in to comment.