Skip to content

Commit

Permalink
Merge pull request #2285 from benthosdev/mihaitodor-fix-ineffective-b…
Browse files Browse the repository at this point in the history
…reak-statement-dynamic-output

Fix ineffective break statement in dynamic output
  • Loading branch information
Jeffail committed Jan 26, 2024
2 parents 58a05f4 + addf2fb commit 78ac5b6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion internal/impl/io/output_dynamic_fan_out.go
Expand Up @@ -257,6 +257,7 @@ func (d *dynamicFanOutOutputBroker) loop() {
_ = atomic.AddInt64(&ackPending, 1)
pendingResponses := int64(len(d.outputs))

outputsLoop:
for _, output := range d.outputs {
select {
case output.tsChan <- message.NewTransactionFunc(ts.Payload.ShallowCopy(), func(ctx context.Context, err error) error {
Expand All @@ -273,7 +274,7 @@ func (d *dynamicFanOutOutputBroker) loop() {
return nil
}):
case <-d.shutSig.CloseAtLeisureChan():
break // This signal will be caught again in the next loop
break outputsLoop // This signal will be caught again in the next loop
}
}
d.outputsMut.RUnlock()
Expand Down

0 comments on commit 78ac5b6

Please sign in to comment.