Skip to content

Commit

Permalink
Fix addQuestionsMarks so it resolves correctly in more cases
Browse files Browse the repository at this point in the history
Fixes this issue: colinhacks#1121

Specifically, `{ property: (T | undefined) & T }` does not seem to
flatten to `{ property: T }` in the case that T is a complex string literal.
  • Loading branch information
bentefay committed May 9, 2022
1 parent c190a84 commit 0aba4d1
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 8 deletions.
13 changes: 9 additions & 4 deletions deno/lib/types.ts
Expand Up @@ -1363,13 +1363,18 @@ export namespace objectUtil {
[k in Exclude<keyof U, keyof V>]: U[k];
} & V;

export type requiredKeys<T extends object> = {
type optionalKeys<T extends object> = {
[k in keyof T]: undefined extends T[k] ? k : never;
}[keyof T];

type requiredKeys<T extends object> = {
[k in keyof T]: undefined extends T[k] ? never : k;
}[keyof T];

export type addQuestionMarks<T extends object> = {
[k in keyof T]?: T[k];
} & { [k in requiredKeys<T>]: T[k] };
export type addQuestionMarks<T extends object> = Partial<
Pick<T, optionalKeys<T>>
> &
Pick<T, requiredKeys<T>>;

export type identity<T> = T;
export type flatten<T extends object> = identity<{ [k in keyof T]: T[k] }>;
Expand Down
13 changes: 9 additions & 4 deletions src/types.ts
Expand Up @@ -1363,13 +1363,18 @@ export namespace objectUtil {
[k in Exclude<keyof U, keyof V>]: U[k];
} & V;

export type requiredKeys<T extends object> = {
type optionalKeys<T extends object> = {
[k in keyof T]: undefined extends T[k] ? k : never;
}[keyof T];

type requiredKeys<T extends object> = {
[k in keyof T]: undefined extends T[k] ? never : k;
}[keyof T];

export type addQuestionMarks<T extends object> = {
[k in keyof T]?: T[k];
} & { [k in requiredKeys<T>]: T[k] };
export type addQuestionMarks<T extends object> = Partial<
Pick<T, optionalKeys<T>>
> &
Pick<T, requiredKeys<T>>;

export type identity<T> = T;
export type flatten<T extends object> = identity<{ [k in keyof T]: T[k] }>;
Expand Down

0 comments on commit 0aba4d1

Please sign in to comment.