Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused import and restored existing checks #1

Merged
merged 4 commits into from May 2, 2022

Conversation

radarhere
Copy link

@radarhere radarhere commented May 1, 2022

Suggestions for python-pillow#6254

  1. You can see that Lint is failing because numbers is imported but unused - https://github.com/python-pillow/Pillow/runs/6245537875?check_suite_focus=true. I've removed the import here.
  2. I've restored the checks for im.point(lambda x: x - 1) and im.point(lambda x: x / 1). Unless you have thoughts otherwise, it seems nicer to keep the previous checks in.
  3. While this may not matter on a practical level, in theory, coerce_e is a public method. So I've added a commit here restoring coerce_e and the data property. I've also kept the original name of _E. Again, it may not matter either way, but I think keeping the same name is better than changing it for now.
  4. However, I have added a commit here deprecating coerce_e. There's no need for users to have access to it, so in future, _E can be changed however we like.

@benrg benrg merged commit 2c726d0 into benrg:affine-transform May 2, 2022
@radarhere radarhere deleted the affine-transform branch May 2, 2022 23:11
benrg pushed a commit that referenced this pull request May 3, 2022
benrg pushed a commit that referenced this pull request May 3, 2022
* Removed unused import

* Restored existing checks

* Restored coerce_e, _E and data property

* Deprecated coerce_e

Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants