Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update util.py #3193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

paoloemilioserra
Copy link

TypeError: 'int' object is not callable

TypeError: 'int' object is not callable
Copy link
Contributor

@pajod pajod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just delete the whole thing. Its in the dead space between two fundamentally incompatible requirements:

  1. Things that depend on unpredictably distributed values should use random data, which the ill-named secrets module provides.
  2. Things that depend on unspecified but reproducible values should ensure a python-version-stable generator with a fixed seed.

Ensuring that carefully timed requests can not defeat a --max-requests mitigation (exhaust server resources on mass worker restart) is clearly in case 1 territory. Ensuring test failures are easy to diagnose is clearly in case 2 territory.

(That is a callable, in the python stdlib. I think your bug is outside of gunicorn code.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants