alias CLD to CHLD in signal handlers #3151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some systems have 17 mapped to both CHLD and CLD, this prevents CHLD from not being handled in this case
|
@jcjones1515 what systems have this ? Can you give an example? |
|
Most of them, just not macOS. Python has even recently updated their documentation to clarify that SIG* is is just whatever the C library says - hence no such alias on macOS, hence no duplicate key bug in SIG_NAMES there. Highly prefer a proper cleanup like the two approaches demonstrated in #3148 over a spot-workaround like this here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some systems have 17 mapped to both CHLD and CLD, this prevents a CHLD signal from being handled in this case
I observed on our systems this issue prevented the arbiter from recognizing a worker getting killed and did not restart it.
This may be addressed by #3148, although that has quite a few other changes. Happy to close this one if #3148 is preferred.