CI: verify minimal dependency versions #3134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajod
force-pushed
the
patch-mindep
branch
2 times, most recently
from
ea460e0
to
290edb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should know our minimum versions, and possibly how they are different depending on python version, e.g. see #2675
This is not the change in minimal dependencies, this is just the necessary duplication (pypa/pip#8085) and hooking it up to GitHub CI. Has everything added as comments though, so after this one is merged, any future PR actually bumping dependencies could have that extra ✅/❌ show up.
The useless header/comment line swap is intentional, works around a bug in GitHub diff syntax highlighting.